Add support for Apple framework builds #2026
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Treata11 <[email protected]>
Signed-off-by: Treata11 <[email protected]>
Signed-off-by: Treata11 <[email protected]>
Signed-off-by: Treata11 <[email protected]>
Signed-off-by: Treata11 <[email protected]>
Signed-off-by: Treata11 <[email protected]>
|
A question about OpenEXRLibraryDefine.cmake. Why does it exist in the first place? It's not utilized anywhere & the LibraryDefine.cmake is used instead... Why two similar files in the first place? |
Signed-off-by: Treata11 <[email protected]>
Signed-off-by: Treata11 <[email protected]>
cary-ilm
reviewed
Apr 29, 2025
| @@ -127,7 +151,7 @@ endif() | |||
| include(CTest) | |||
|
|
|||
| if(BUILD_TESTING AND OPENEXR_BUILD_LIBS AND NOT OPENEXR_IS_SUBPROJECT) | |||
| add_subdirectory(src/test) | |||
| add_subplot(src/test) | |||
cary-ilm
reviewed
Apr 29, 2025
| option(OPENEXR_FRAMEWORK "Build as Apple Frameworks" OFF) | ||
| endif () | ||
|
|
||
| if(OPENEXR_FRAMEWORK) |
There was a problem hiding this comment.
I'd prefer to name this OPENEXR_BUILD_APPLE_FRAMEWORKS
cary-ilm
reviewed
Apr 29, 2025
| @@ -102,6 +121,11 @@ if(OPENEXR_BUILD_EXAMPLES AND OPENEXR_BUILD_LIBS) | |||
| add_subdirectory( src/examples ) | |||
| endif() | |||
|
|
|||
| if (OPENEXR_BUILD_LIBS AND NOT OPENEXR_IS_SUBPROJECT) | |||
There was a problem hiding this comment.
Is there a reason this moved? Better to minimize changes unless there's a specific reason.
cary-ilm
reviewed
Apr 29, 2025
| set_target_properties(${libname} PROPERTIES | ||
| OUTPUT_NAME "${libname}${OPENEXR_LIB_SUFFIX}" | ||
| OUTPUT_NAME "${libname}" |
There was a problem hiding this comment.
The output name needs the OPENEXR_LIB_SUFFIX.
cary-ilm
reviewed
Apr 29, 2025
| @@ -384,4 +384,4 @@ int main() { | |||
| if(NOT HAS_VLD1) | |||
| set(OPENEXR_MISSING_ARM_VLD1 TRUE) | |||
| endif() | |||
| endif() | |||
| endif() | |||
There was a problem hiding this comment.
Why remove the newline?
In fact, it looks like all your edited files now lack a newline as the final character, which is odd, an artifact of your text editor, perhaps? Please add them back in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.