Fix typos in Examples subdirectory #216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found via codespell Signed-off-by: luzpaz <[email protected]>
garyo
requested changes
Oct 8, 2025
Examples/ColourSpace/colourspace.cpp
Outdated
| gEffectHost->getPropertySet(effect, &effectProps); | ||
|
|
||
| // retieve the colour management style that the host has decided we shall use | ||
| // reteive the colour management style that the host has decided we shall use |
Contributor
There was a problem hiding this comment.
Should be "retrieve" (and below)
Contributor
|
Sorry, one more thing @luzpaz — all commits must have a "Signed-Off-By: " line at the end so we can track contributions for legal reasons. Could you redo your commit with a force-push? |
Signed-off-by: luzpaz <[email protected]>
Found via codespell Signed-off-by: luzpaz <[email protected]>
Found via codespell Signed-off-by: luzpaz <[email protected]>
AKA the Open Effects Association. Signed-off-by: Gary Oberbrunner <[email protected]>
Also update the doc build script to use `uv` if present. That's nicer because you don't have to manually create a python venv or install depencies. Removed old unused footer, and marked ofx-header and ofx-footer as unused. Signed-off-by: Gary Oberbrunner <[email protected]>
luzpaz
force-pushed
the
typos-examples
branch
from
ab87c05 to
a67a271
Compare
Contributor
Author
|
I hope I did the rebase and amend correctly 🤞 |
garyo
added a commit
that referenced
this pull request
Oct 13, 2025
Signed-off-by: Gary Oberbrunner <[email protected]>
garyo
added a commit
that referenced
this pull request
Oct 13, 2025
Signed-off-by: Gary Oberbrunner <[email protected]>
Contributor
|
Hmm, somehow the new version pulled in a bunch of other stuff. No worries, I pulled your diff into a new PR and applied it. Thanks very much for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via codespell