Bug fix: LevelSetFilter.h and TestGrid.cc in feature/half_grid_support compile
#2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent integer overflow on grids with many nodes or leafs. Signed-off-by: ghurstunither <[email protected]>
…on Library (PDAL) * Uses any available pdal plugin to read input file * Writes RGB into Cd channel of points (also extended to PTS implementation) * Adds a requirement on PDAL, so hidden behind a feature VDB_TOOL_USE_PDAL - off by default Signed-off-by: Tom Matterson <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
…Node(s) Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
…se_pdal Merge master, added libpdal to new install_windows ps script
Signed-off-by: Jonathan Swartz <[email protected]>
leafCount, unallocatedLeafCount, nodeCount now work with Index64 to accommodate trees with more than 2^32-1 leaf nodes. Signed-off-by: ghurstunither <[email protected]>
Correct type for variable. Signed-off-by: ghurstunither <[email protected]>
Turns off OPENVDB_BUILD_UNITTESTS. Signed-off-by: ghurstunither <[email protected]>
…ions Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
…eFoundation/v12.0.0_rc VDB 12.0.0 Release
Signed-off-by: Dan Bailey <[email protected]>
Meeting notes from 2024-11-05. Signed-off-by: ghurstunither <[email protected]>
Some corrections suggested by Andre. Signed-off-by: ghurstunither <[email protected]>
…eFoundation/meeting_notes/2024-11-05 2024-11-05 Meeting Notes
…ndation#1971) * added read/write support of OFF files to vdb_tool Signed-off-by: Ken Museth <[email protected]> * added pendingchanges/vdb_tool.txt Signed-off-by: Ken Museth <[email protected]> * added patch from Jonathan S Signed-off-by: Ken Museth <[email protected]> * minor cleanup Signed-off-by: Ken Museth <[email protected]> * addressed review comments Signed-off-by: Ken Museth <[email protected]> * before major improvements to readPLY Signed-off-by: Ken Museth <[email protected]> * cleanup Signed-off-by: Ken Museth <[email protected]> * removed whitespace Signed-off-by: Ken Museth <[email protected]> * added nanovdb::vdb_tool::swapBytes Signed-off-by: Ken Museth <[email protected]> * added more documentation Signed-off-by: Ken Museth <[email protected]> * patch by Jonathan S to fix CI Signed-off-by: Ken Museth <[email protected]> * Fix gtest install for rpm. not deb Signed-off-by: Jonathan Swartz <[email protected]> * Building gtest from source; newer version required than available on distro Signed-off-by: Jonathan Swartz <[email protected]> * permissions fix Signed-off-by: Jonathan Swartz <[email protected]> * Attempting to fix doxygen node version issue Missing iomanip include in TestNanoVDB Signed-off-by: Jonathan Swartz <[email protected]> * Bump container versions attempt to fix doxygen test Signed-off-by: Jonathan Swartz <[email protected]> * install_latex fix Signed-off-by: Jonathan Swartz <[email protected]> * added ascii option to Geometry::writePLY Signed-off-by: Ken Museth <[email protected]> * fixing issue introduced in the previous commit Signed-off-by: Ken Museth <[email protected]> --------- Signed-off-by: Ken Museth <[email protected]> Signed-off-by: Jonathan Swartz <[email protected]> Co-authored-by: Jonathan Swartz <[email protected]>
Upcoming versions of Clang/LLVM change some behaviour around templating that causes OpenVDB to fail to compile. This commit addresses two issues and allows VDB to compile again. 1. There were three instances of an unnecessary template keyword in NodeManager.h that were not followed by a template call, and therefore are illegal to the compiler. 2. GridBuilder.h had a template call to a non-existent method. This was not previously validated, but is now validated. Switching the symbol from `isActive` to `isOn` per Ken's review. See the [changelog](https://releases.llvm.org/19.1.0/tools/clang/docs/ReleaseNotes.html#improvements-to-clang-s-diagnostics:~:text=Clang%20now%20looks%20up%20members%20of%20the%20current%20instantiation%20in%20the%20template%20definition%20context%20if%20the%20current%20instantiation%20has%20no%20dependent%20base%20classes.) for Clang and the associated [PR for the second point above](llvm/llvm-project#84050) Signed-off-by: Dhruv Govil <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
…ion#1982 Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
…_notes_031224 Meeting notes 3rd December
Changed GH action upload-artifact to v4; fixes AcademySoftwareFoundation#1982
…eFoundation/fix_missing_spdx Added SPDX license identifiers to files missing it
Signed-off-by: Jonathan Swartz <[email protected]>
…_typo Fix typo in SPDX license identifier
Initial support for HalfGrid and ComputeType, where the latter enables float computations for HalfGrid which increases accuracy and speed. Signed-off-by: ghurstunither <[email protected]>
Remove HalfGrid from RealGridTypes until a consensus is reached. Signed-off-by: ghurstunither <[email protected]>
Fixes trailingspaces errors Signed-off-by: ghurstunither <[email protected]>
…support in LevelSetFilter. Signed-off-by: apradhana <[email protected]>
Signed-off-by: apradhana <[email protected]>
Signed-off-by: apradhana <[email protected]>
apradhana
force-pushed
the
half_grid_pass_unit_test
branch
2 times, most recently
from
930e67b to
eb88c84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LevelSetFilter.hto not support Half. We want to make sure that this file compiles first.TestGrid.cccompiles