Remove unnecessary null pointer checks (ASWF issue #257) #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dation#257. There only appeared to be one obvious case left. Code search process: grep -C 3 delete . ... then look for if statements, in C-like code, conditioned on the same variable, and no other obvious purpose that required the if statement. Signed-off-by: Eric Powers <[email protected]>
…ly goes out of scope. Signed-off-by: Eric Powers <[email protected]>
|
|
CLA Not Signed... working this internally... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix remove unnecessary set local variable to null before it immediately goes out of scope. N
Fix remove unnecessary null pointer checks, issue #257.
There only appeared to be one obvious case left.
Code search process:
... then look for if statements, in C-like code, conditioned on the same variable, and no other obvious purpose that required the if statement.
See:
#257
Note: one of the two commits doesn't technically match the paradigm raised in the issue, but setting a pointer variable to nullptr immediately before it goes out of scope is unnecessary.