Add I/O ReadOptions and WriteOptions - #2184
Merged
danrbailey merged 6 commits intoMay 7, 2026
Merged
Conversation
danrbailey
force-pushed
the
io_options
branch
5 times, most recently
from
March 26, 2026 21:44
c0e405b to
7366b60
Compare
danrbailey
requested review from
Idclip,
apradhana,
jmlait and
richhones
as code owners
April 21, 2026 22:37
Signed-off-by: Dan Bailey <danbailey@ilm.com>
Signed-off-by: Dan Bailey <danbailey@ilm.com>
Signed-off-by: Dan Bailey <danbailey@ilm.com>
Signed-off-by: Dan Bailey <danbailey@ilm.com>
jmlait
approved these changes
Apr 29, 2026
Signed-off-by: Dan Bailey <danbailey@ilm.com>
danrbailey
merged commit May 7, 2026
d1438a1
into
AcademySoftwareFoundation:feature/io
43 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the existing I/O API - Archive, File, Stream to add
io::ReadOptionsandio::WriteOptionsas arguments.All private and protected member functions have been updated to work with these two new classes instead, which replaces filtering arguments such as bbox-filtering and partial topology-only options.
There is no breakages to the public API. At present
io::WriteOptionsdoes nothing. Existing read methods that expose filtering arguments such as bbox now create a localio::ReadOptionsinstance and call through to the new methods. In subsequent PRs, ReadOptions will continue to grow with new filtering options that were not previously available.All unit tests continue to pass.