Renaming of MergeGrids in nanovdb/tools/cuda to TopologyUnion - #2246
Open
A-PS1999 wants to merge 1 commit into
Open
Renaming of MergeGrids in nanovdb/tools/cuda to TopologyUnion#2246A-PS1999 wants to merge 1 commit into
A-PS1999 wants to merge 1 commit into
Conversation
Signed-off-by: A-PS1999 <sarnoldparra@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that issue #2242 was raised and thought that it looked like a good first issue for someone like me, new to this project, to contribute.
As the name and description of the issue suggests, I renamed MergeGrids to TopologyUnion within the
nanovdb/nanovdb/tools/cudadirectory and other directories which seemed relevant such asnanovdb/nanovdb/examples/ex_merge_nanovdb_cuda. Since the issue only referred to making the rename change in the CUDA related directories I didn't, for example, rename it innanovdb/nanovdb/GridHandle.h.I am of course open to feedback on this PR and can make any necessary adjustments as required.