add more CI platforms #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Dukhovnikov <[email protected]>
soswow
reviewed
Apr 18, 2025
| else if ( wl > 780 ) | ||
| break; | ||
|
|
||
| _cmf[i]._wl = wl; |
Contributor
There was a problem hiding this comment.
I don't know what this is doing, but I can see how previously we would change _wl value before all the checks, where is now we apply it only if checks are passed. I assume that is intentional and fixes some problem?
Contributor
Author
There was a problem hiding this comment.
The original code first reads the wavelength into the next item of the array and then checks if it is in bounds. It can crash if the file contains more spectral samples than the tool expects (81). There are actually other places with the same bug, but this one does crash periodically as the cmd file does contain more samples.
antond-weta
merged commit 4ac227d
into
AcademySoftwareFoundation:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds VFX2022 and VFX2024 CI runners.
Fixes the build on VFX2022 (Centos 7).
Fixes a few deprecation warnings.
Fixes a potential crash writing out of bounds.