-
Notifications
You must be signed in to change notification settings - Fork 57
switch to rawtoaces_data repo #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to rawtoaces_data repo #149
Conversation
|
converting this to a draft for now, as I'd like to make some more changes to the data repo |
6b27c84 to
1ebd8f2
Compare
|
Sorry, coming late (I was on a break). Is there a specific reason for not using a Git sub-module here that is pulled when cloning the repo? |
I don't have a specific reason, as this is the first time I'm doing this. I believe Kimball had advised me against using sub-modules here (unless I misunderstood badly). |
|
It would be awesome for @kdt3rd to comment as this is adding quite a bit of code for functionality that we get for free basically with Git. |
Signed-off-by: Anton Dukhovnikov <[email protected]>
Signed-off-by: Anton Dukhovnikov <[email protected]>
Signed-off-by: Anton Dukhovnikov <[email protected]>
Signed-off-by: Anton Dukhovnikov <[email protected]>
1ebd8f2 to
7b81857
Compare
|
@KelSolaar I would suggest merging this as is for now, if you don't have any other concerns. I understand that we can switch to using git sub-modules later if needed, the change is self-contained and does not affect anything else. A couple of arguments in support of the current solution off the top of my head:
|
|
Certainly fine by me! |
cd0eab2
into
AcademySoftwareFoundation:master
Switch to using external repo for camera data.