switch from AMPAS_DATA_PATH to RAWTOACES_DATA_PATH environment variable #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antond-weta
force-pushed
the
rawtoaces_data_path
branch
2 times, most recently
from
47d7f4f to
87a5f97
Compare
soswow
approved these changes
Aug 6, 2025
| env = getenv( "RAWTOACES_DATA_PATH" ); | ||
| if ( !env ) | ||
| // Fallback to the old environment variable. | ||
| env = getenv( "AMPAS_DATA_PATH" ); |
Contributor
There was a problem hiding this comment.
/nit random thought - maybe throw some warning message into console saying that this one is deprecated now and they should switch to a new one?
Contributor
Author
There was a problem hiding this comment.
good idea. done!
soswow
reviewed
Aug 6, 2025
| $ rawtoaces --wb-method 1 D60 --mat-method 0 input.raw | ||
|
|
||
| You can use the environment varilable of `AMPAS_DATA_PATH` to specify the repository for your own datasets. If you have spectral sensitivity data for your camera but it is not included with `rawtoaces` you may place that data in `/usr/local/include/rawtoaces/data/camera` or place the data in the folder pointed by `AMPAS_DATA_PATH`. | ||
| You can use the environment variable of `RAWTOACES_DATA_PATH` to specify the repository for your own datasets. If you have spectral sensitivity data for your camera but it is not included with `rawtoaces` you may place that data in `/usr/local/include/rawtoaces/data/camera` or place the data in the folder pointed by `RAWTOACES_DATA_PATH`. The rawtoaces versions prior to v1.1 used the environment variable `AMPAS_DATA_PATH`, the old name is still supported for backward compatibility. If both variables are present, `RAWTOACES_DATA_PATH` takes priority. |
Contributor
There was a problem hiding this comment.
Is there a place that describes what is expected structure of this folder?
Signed-off-by: Anton Dukhovnikov <[email protected]>
Signed-off-by: Anton Dukhovnikov <[email protected]>
antond-weta
force-pushed
the
rawtoaces_data_path
branch
from
6cf3a0e to
2b9d3d6
Compare
soswow
approved these changes
Aug 6, 2025
antond-weta
merged commit f144c72
into
AcademySoftwareFoundation:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.