Various small fixes and spellcheck #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Motsjonov <[email protected]>
antond-weta
reviewed
Aug 11, 2025
README.md
Outdated
| * [`test/`](./test) - Sample testing materials such as a ".NEF" RAW image and a camera spectral sensitivity data file | ||
| * [`main.cpp`](main.cpp) - C++ source code file for call routines to process images | ||
| * [`include/`](./include) - Public header files for the `rawtoaces` library | ||
| * [`src/`](./src) - Source code for `rawtoaces` utilities and IDT implementation |
Contributor
There was a problem hiding this comment.
Perhaps 'source code for the core library, utility library, and the command line tool', or something like that could be better?
antond-weta
reviewed
Aug 11, 2025
README.md
Outdated
| * [`include/`](./include) - Public header files for the `rawtoaces` library | ||
| * [`src/`](./src) - Source code for `rawtoaces` utilities and IDT implementation | ||
| * [`unittest/`](./unittest) - Unit tests for `rawtoaces` | ||
| * [`main.cpp`](./src/rawtoaces/main.cpp) - C++ source file for call routines to process images |
Contributor
There was a problem hiding this comment.
Since that file has been moved to src, I'd rather get this line removed completely, or get all subfolder listed for consistency.
antond-weta
reviewed
Aug 11, 2025
README.md
Outdated
| * [`build_scripts/`](./build_scripts) - Helper scripts for installing dependencies | ||
| * [`cmake/`](./cmake) - CMake modules for locating dependencies (e.g., `libraw`) | ||
| * [`config/`](./config) - CMake configuration files | ||
| * [`data/`](./data) - Data files containing camera sensitivity, light source, color matching function and 190 training patch data |
Contributor
There was a problem hiding this comment.
not a part of your change, but we should remove the data folder mentioned here, as it's not in the repo anymore
Contributor
|
looks good, put a few small comments there |
antond-weta
force-pushed
the
random-fixes-2
branch
from
811b058 to
50621b9
Compare
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Contributor
|
great, thank you |
antond-weta
merged commit 22b83ce
into
AcademySoftwareFoundation:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing ChatGPT Codex thingy and it were sample tasks it had. Some of them I thought were ok to propose as a change.