Skip to content

Conversation

@antond-weta
Copy link
Contributor

No description provided.

boost-system:x64-windows \
boost-foreach:x64-windows \
boost-filesystem:x64-windows \
boost-system:x64-windows \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate of 9th line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@soswow soswow Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make it blow up if 17 requirement is not met:

On Line 3:

if(NOT DEFINED CMAKE_CXX_STANDARD)
  set(CMAKE_CXX_STANDARD 17)
endif()
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not. I'm using some of C++20 features in my v2 branch, so this is getting complicated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

system
filesystem
unit_test_framework
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you of this:

The goal is to prefer CMake package config (vcpkg/Conan), fall back to FindBoost for distro installs

find_package ( Boost         CONFIG QUIET
    COMPONENTS
        system
        unit_test_framework
)
if (NOT Boost_FOUND)
    find_package ( Boost REQUIRED
        COMPONENTS
            system
            unit_test_framework
    )
endif()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too worried about this. Boost is going away in the next couple of PRs. Definitely before the next release.

Signed-off-by: Anton Dukhovnikov <[email protected]>
@antond-weta antond-weta merged commit a8bad07 into AcademySoftwareFoundation:master Aug 14, 2025
13 checks passed
@antond-weta antond-weta deleted the std_filesystem branch August 14, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants