-
Notifications
You must be signed in to change notification settings - Fork 57
replace boost::filesystem with std::filesystem #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace boost::filesystem with std::filesystem #161
Conversation
Signed-off-by: Anton Dukhovnikov <[email protected]>
| boost-system:x64-windows \ | ||
| boost-foreach:x64-windows \ | ||
| boost-filesystem:x64-windows \ | ||
| boost-system:x64-windows \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate of 9th line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to make it blow up if 17 requirement is not met:
On Line 3:
if(NOT DEFINED CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 17)
endif()
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, why not. I'm using some of C++20 features in my v2 branch, so this is getting complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| system | ||
| filesystem | ||
| unit_test_framework | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you of this:
The goal is to prefer CMake package config (vcpkg/Conan), fall back to FindBoost for distro installs
find_package ( Boost CONFIG QUIET
COMPONENTS
system
unit_test_framework
)
if (NOT Boost_FOUND)
find_package ( Boost REQUIRED
COMPONENTS
system
unit_test_framework
)
endif()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too worried about this. Boost is going away in the next couple of PRs. Definitely before the next release.
Signed-off-by: Anton Dukhovnikov <[email protected]>
a8bad07
into
AcademySoftwareFoundation:master
No description provided.