Add initial unit tests for ImageConverter::parse_parameters #194
Conversation
…inants Signed-off-by: Aleksandr Motsjonov <[email protected]>
| pos += 1; | ||
| } | ||
| // Subtract 1 for the header line | ||
| illuminant_count = ( illuminant_count > 0 ) ? illuminant_count - 1 : 0; |
There was a problem hiding this comment.
Happy to drop that part. Makes test too fragile. If we decide to add some post-message after list of illuminants - it will blow up, which might not what we want. At the same time if we decide to add a new hardcoded illuminant, this test won't brake, even though we might want it to.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 73.29% 74.20% +0.90%
==========================================
Files 10 10
Lines 2198 2198
Branches 237 237
==========================================
+ Hits 1611 1631 +20
+ Misses 587 567 -20 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Oof. For some unexplainable reason I don't like this at all. Can we create some fake camera and illuminant files on the fly? Presumably you don't need them to be fully formed spectral json, you only need the |
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
| "description" : "data for unit tests", | ||
| "document_creator" : "sasha", | ||
| "document_creation_date" : "2017-04-11T12:00:00Z", | ||
| "license" : "Some-License-4.2" |
There was a problem hiding this comment.
I believe everything we put into this repo has to be under Apache-2.0, as per the project charter.
| "data": { | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
so why not remove even more unnecessary data and create the files on the fly?
| { | ||
| "header": { | ||
| "schema_version" : "0.1.0", | ||
| "illuminant" : "iso4242", |
There was a problem hiding this comment.
Quite interesting!
ISO 4242:1980
Cinematography — Recording head gaps for two sound records on 16 mm magnetic film — Positions and width dimensions
Maybe use a more generic name, unrelated to any standards?
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
3 participants
No description provided.