Skip to content

Conversation

@rodeka
Copy link
Contributor

@rodeka rodeka commented Sep 16, 2025

Fixes #196

Summary:

  • Remove hardcoded training set size; compute from dataset at runtime
  • Run clang-format; all tests passing locally (CMake/CTest)

Note:

  • No public API changes

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 16, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rodeka / name: rodeka (0014bd7)

@rodeka rodeka force-pushed the fix/issue-196-remove-hardcoded-size branch from 8827478 to 0014bd7 Compare September 16, 2025 10:10
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.40%. Comparing base (94d2d16) to head (0014bd7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   74.39%   74.40%   +0.01%     
==========================================
  Files          10       10              
  Lines        2226     2227       +1     
  Branches      292      292              
==========================================
+ Hits         1656     1657       +1     
  Misses        570      570              
Files with missing lines Coverage Δ
src/rawtoaces_core/mathOps.h 99.30% <100.00%> (+<0.01%) ⬆️
src/rawtoaces_core/rawtoaces_core.cpp 86.15% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d2d16...0014bd7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@antond-weta
Copy link
Contributor

LGTM, thanks!

@antond-weta antond-weta merged commit c2a61d2 into AcademySoftwareFoundation:main Sep 17, 2025
26 checks passed
@antond-weta
Copy link
Contributor

Hey @rodeka, your fix is going to be in the next release, hopefully. Would you like to give me your full name to put on the contributors list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the hardcoded training set size

3 participants