-
Notifications
You must be signed in to change notification settings - Fork 57
Fix macos CI pipeline #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macos CI pipeline #214
Conversation
Signed-off-by: Aleksandr Motsjonov <[email protected]>
|
so, it fails with it tries to write back to where code is. In this case at But what has changed? Why is it suddenly unable to write? |
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
| "chromaticities", | ||
| OIIO::TypeDesc( OIIO::TypeDesc::FLOAT, 8 ), | ||
| chromaticities ); | ||
| image_spec["oiio:ColorSpace"] = "lin_ap0_scene"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core fix
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 72.62% 72.53% -0.10%
==========================================
Files 10 10
Lines 2108 2112 +4
Branches 317 317
==========================================
+ Hits 1531 1532 +1
- Misses 577 580 +3
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Aleksandr Motsjonov <[email protected]>
antond-weta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Main CI for macos is most likely broken. This PR is where we prove it and fix it.