Skip to content

Conversation

@soswow
Copy link
Contributor

@soswow soswow commented Nov 13, 2025

Main CI for macos is most likely broken. This PR is where we prove it and fix it.

Signed-off-by: Aleksandr Motsjonov <[email protected]>
@soswow soswow changed the title Commit to demo problem with the build Fix macos CI pipeline Nov 13, 2025
@soswow
Copy link
Contributor Author

soswow commented Nov 13, 2025

so, it fails with

 2/12 Test  #2: Test_usage_example_util ..........***Failed    0.80 sec
Failed to save the file: /Users/runner/work/rawtoaces/rawtoaces/build/tests/../../tests/materials/blackmagic_cinema_camera_cinemadng_aces.exr
/Users/runner/work/rawtoaces/rawtoaces/tests/usage_example_util.cpp:42:
FAILED: result
Failed to save the file: /Users/runner/work/rawtoaces/rawtoaces/build/tests/../../tests/materials/blackmagic_cinema_camera_cinemadng_aces.exr
/Users/runner/work/rawtoaces/rawtoaces/tests/usage_example_util.cpp:69:
FAILED: result
ERRORS!

it tries to write back to where code is. In this case at /Users/runner/work/rawtoaces/rawtoaces/tests/materials/blackmagic_cinema_camera_cinemadng_aces.exr and can't do it.
It prob. easy to fix and point it to some definetely writable place like tmp folder.

But what has changed? Why is it suddenly unable to write?

Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
Signed-off-by: Aleksandr Motsjonov <[email protected]>
"chromaticities",
OIIO::TypeDesc( OIIO::TypeDesc::FLOAT, 8 ),
chromaticities );
image_spec["oiio:ColorSpace"] = "lin_ap0_scene";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core fix

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.53%. Comparing base (a49c1a9) to head (b6f4c12).

Files with missing lines Patch % Lines
src/rawtoaces_util/image_converter.cpp 25.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   72.62%   72.53%   -0.10%     
==========================================
  Files          10       10              
  Lines        2108     2112       +4     
  Branches      317      317              
==========================================
+ Hits         1531     1532       +1     
- Misses        577      580       +3     
Files with missing lines Coverage Δ
src/rawtoaces_util/image_converter.cpp 54.65% <25.00%> (-0.12%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49c1a9...b6f4c12. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Aleksandr Motsjonov <[email protected]>
Copy link
Contributor

@antond-weta antond-weta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antond-weta antond-weta merged commit 439d1fb into AcademySoftwareFoundation:main Nov 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants