Skip to content

Conversation

@antond-weta
Copy link
Contributor

Description

The const qualifier on hints added in 215 breaks conversion. Rolling that change back.

Tests

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable. (Check if there is no
    need to update the documentation, for example if this is a bug fix that
    doesn't change the API.)
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format before submitting, I definitely will look at the CI
    test that runs clang-format and fix anything that it highlights as being
    nonconforming.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.42%. Comparing base (79c91eb) to head (c8e73a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   81.44%   81.42%   -0.02%     
==========================================
  Files          11       11              
  Lines        2150     2148       -2     
  Branches      325      325              
==========================================
- Hits         1751     1749       -2     
  Misses        399      399              
Files with missing lines Coverage Δ
include/rawtoaces/image_converter.h 100.00% <ø> (ø)
src/rawtoaces_util/image_converter.cpp 71.49% <ø> (-0.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c91eb...c8e73a0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@soswow soswow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually prefer to have regression test to accompony the revert/bug-fix. But it's ok to merge first and think of testing later.

@antond-weta antond-weta merged commit e830eea into AcademySoftwareFoundation:main Nov 26, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants