Skip to content

Conversation

@antond-weta
Copy link
Contributor

Description

Updated the code to use the spectral json schema version 1.0.0.
Switched to rawtoaces_data v1.0.0.

Tests

Added tests to make sure that older schema version files still work.

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable. (Check if there is no
    need to update the documentation, for example if this is a bug fix that
    doesn't change the API.)
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format before submitting, I definitely will look at the CI
    test that runs clang-format and fix anything that it highlights as being
    nonconforming.

Signed-off-by: Anton Dukhovnikov <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.49%. Comparing base (e830eea) to head (bc8edc7).

Files with missing lines Patch % Lines
src/rawtoaces_core/rawtoaces_core.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   81.42%   81.49%   +0.07%     
==========================================
  Files          11       11              
  Lines        2148     2151       +3     
  Branches      325      327       +2     
==========================================
+ Hits         1749     1753       +4     
+ Misses        399      398       -1     
Files with missing lines Coverage Δ
include/rawtoaces/spectral_data.h 100.00% <ø> (ø)
src/rawtoaces_core/spectral_data.cpp 78.78% <100.00%> (+0.32%) ⬆️
src/rawtoaces_util/image_converter.cpp 71.49% <100.00%> (ø)
src/rawtoaces_core/rawtoaces_core.cpp 88.98% <66.66%> (+0.18%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e830eea...bc8edc7. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rawtoaces_data
GIT_REPOSITORY https://github.com/AcademySoftwareFoundation/rawtoaces-data
GIT_TAG 4db0acc872965ecdbbf578664be20abf17c18e8c # v0.1.0
GIT_TAG 265e0038826572439d23934120f4bc69c19933e3 # v1.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

Signed-off-by: Anton Dukhovnikov <[email protected]>
Signed-off-by: Anton Dukhovnikov <[email protected]>
@antond-weta antond-weta merged commit 0b3db70 into AcademySoftwareFoundation:main Nov 27, 2025
18 checks passed
@antond-weta antond-weta deleted the schema_1.0.0 branch November 27, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants