-
Notifications
You must be signed in to change notification settings - Fork 343
First pass at defining our threat model and security policy #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JeanChristopheMorinPerso
wants to merge
4
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
JeanChristopheMorinPerso:threat_model_and_security_policy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
99839c9
First pass at defining our threat model and security policy
JeanChristopheMorinPerso 1f02338
Move security details into the docs
JeanChristopheMorinPerso 1713962
Fix Sphinx syntax
JeanChristopheMorinPerso 703f0d6
Restructure and add more information. Still a long way to go
JeanChristopheMorinPerso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# Security Policy | ||
|
||
All security information can be found in https://rez.readthedocs.io/en/stable/security.html. | ||
|
||
## Supported Versions | ||
|
||
We only support the latest version. We try our best to keep rez backward | ||
compatible as much as possible, which allows us to to only support the latest version. | ||
|
||
## Reporting a Vulnerability | ||
|
||
If you think you've found a potential vulnerability in rez, please report it by filing a GitHub [security | ||
advisory](https://github.com/AcademySoftwareFoundation/rez/security/advisories/new). | ||
|
||
Our policy is to acknowledge the receipt of vulnerability reports within 72 hours. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,8 @@ | |
Caching | ||
======= | ||
|
||
.. _resolve-caching: | ||
|
||
Resolve Caching | ||
=============== | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,7 @@ Welcome to rez's documentation! | |
managing_packages | ||
caching | ||
pip | ||
security | ||
|
||
.. toctree:: | ||
:maxdepth: 2 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
======== | ||
Security | ||
======== | ||
|
||
.. important:: | ||
This page is a work in progress. | ||
|
||
.. todo:: List assumptions (rez will run inside an internal network, we assume good intentions, package definitions are written in python and executed). Access to shared filesystem. | ||
.. todo:: File permissions | ||
.. todo:: How to mitigate risks | ||
|
||
Main features | ||
============= | ||
|
||
There is two main functionalities: building packages and resolving packages. Building a package could imply downloading | ||
and executing code. We don't control how a package is built or what happens during a build. | ||
|
||
Missing security features | ||
========================= | ||
|
||
This is a list of security features that rez currently lacks (as of 3.0.0). Some are not implemented | ||
because they don't make sense for rez, some are missing because we have not yet have time to implement | ||
them. | ||
|
||
* No concept of central package registry that studios can download packages from. | ||
* No concept of artifact. Packages today are directories on a file system. | ||
* No concept of package signature (due to the lack of artifact concept). | ||
|
||
Security considerations | ||
======================= | ||
|
||
Designed to be run within a safe environment | ||
-------------------------------------------- | ||
|
||
rez was designed to be used in a studio environment where the environment is trusted. | ||
|
||
Package definitions are python files | ||
------------------------------------ | ||
|
||
Package definitions, both for building packages and resulting from a build are Python files (``package.py``) Rez will read and load them in memory at resolve time. | ||
|
||
* Packages can inject environment variables into the resulting shells via | ||
:doc:`package commands <package_commands>`. | ||
* Packages can inject arbitrary commands to be executed when the shells are started | ||
via :doc:`package commands <package_commands>`. | ||
|
||
Config files can be written in YAML or Python | ||
--------------------------------------------- | ||
|
||
Config files written in Python can contain arbitrary code. | ||
|
||
Config files will be loaded from default paths (see :doc:`configuring_rez`). One of the default path is | ||
the user home folder and it can be disabled using :envvar:`REZ_DISABLE_HOME_CONFIG` if this is a security | ||
concern. It's also posssible to tell rez to load them from any arbitrary path using the :envvar:`REZ_CONFIG_FILE` | ||
environment variable which can contain more than one path. | ||
|
||
Heavy use of subprocesses and sub-shells | ||
---------------------------------------- | ||
|
||
It will create new shells via subprocesses. | ||
|
||
.. todo:: With that in mind, the main entry points are config files (written in python) and package definition files. | ||
|
||
Communication with outside services | ||
=================================== | ||
|
||
By default rez doesn't communicate with outside services. | ||
|
||
AMQP Server | ||
----------- | ||
|
||
Send context information, release events, etc. | ||
|
||
.. todo:: Expand | ||
|
||
memcached Server | ||
---------------- | ||
|
||
`memcached <https://memcached.org/>`_ can be used to speed up resolves by caching them in memcached. memcached | ||
is a very simple server and it should not be exposed to the internet. The data is sent and stored unencrypted. | ||
|
||
See :ref:`resolve-caching` for more information on how to configure rez with a memcached server. |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 72 hours is reasonable for a first response. Any opinions?