Move winreg import to local import to avoid import errors on non-windows systems #1846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows systems Signed-off-by: Jean-Christophe Morin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1846 +/- ##
==========================================
+ Coverage 57.44% 58.58% +1.13%
==========================================
Files 126 126
Lines 17136 17207 +71
Branches 3017 3014 -3
==========================================
+ Hits 9844 10080 +236
+ Misses 6636 6474 -162
+ Partials 656 653 -3 ☔ View full report in Codecov by Sentry. |
JeanChristopheMorinPerso
merged commit fe13e89
into
AcademySoftwareFoundation:main
44 of 45 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #1780. #1780 introduced an import error while loading the pwsh plugin on non-windows systems which caused the plugin to never be loaded. See https://github.com/AcademySoftwareFoundation/rez/actions/runs/11317037020/job/31504575012#step:8:363.