Add support for synchronous and asynchronous modes in package cache #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1853 +/- ##
==========================================
- Coverage 59.30% 59.28% -0.02%
==========================================
Files 126 126
Lines 17210 17217 +7
Branches 3015 3017 +2
==========================================
+ Hits 10206 10207 +1
- Misses 6319 6325 +6
Partials 685 685 ☔ View full report in Codecov by Sentry. |
Pixel-Minions
force-pushed
the
Add-support-for-synchronous-mode-in-rez-pkg-cache
branch
from
8fc7b01 to
c21b725
Compare
- Introduced a new command-line argument `--pkg-cache-mode` to specify caching mode. - Allows users to choose between 'sync' and 'async' modes, overriding the default configuration. - Updated `add_variant` function to handle the new caching mode option. - Ensures backward compatibility by maintaining default behavior when no mode is specified. Signed-off-by: Jose Enriquez <[email protected]>
Pixel-Minions
force-pushed
the
Add-support-for-synchronous-mode-in-rez-pkg-cache
branch
from
c21b725 to
b49ef51
Compare
JeanChristopheMorinPerso
requested changes
Oct 14, 2024
Signed-off-by: Jose Enriquez <[email protected]> Co-authored-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Jose Enriquez <[email protected]>
Signed-off-by: Jose Enriquez <[email protected]> Co-authored-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Jose Enriquez <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
approved these changes
Oct 19, 2024
Member
JeanChristopheMorinPerso
left a comment
JeanChristopheMorinPerso
left a comment
There was a problem hiding this comment.
Thank you @Pixel-Minions!
JeanChristopheMorinPerso
merged commit effa516
into
AcademySoftwareFoundation:main
44 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--pkg-cache-modeto specify caching mode.add_variantfunction to handle the new caching mode option.