Skip to content

Conversation

@cfxegbert
Copy link
Contributor

Fixes #1438

os.path.realpath on Python 3.8 Windows changed. When resolving mapped drive realpath returns the UNC path without the drive letter.

This pull restores the Python 3.7 Windows behavior of realpath being a wrapper around abspath. The behavior can be changed with the rezconfig setting windows_unc_path

@cfxegbert cfxegbert requested a review from a team as a code owner October 15, 2024 00:36
@codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.31%. Comparing base (491497f) to head (0903ec3).
⚠️ Report is 78 commits behind head on main.

Files with missing lines Patch % Lines
src/rez/rezconfig.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1856      +/-   ##
==========================================
+ Coverage   59.30%   59.31%   +0.01%     
==========================================
  Files         126      126              
  Lines       17210    17217       +7     
  Branches     3015     3016       +1     
==========================================
+ Hits        10206    10212       +6     
- Misses       6319     6320       +1     
  Partials      685      685              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ped drive letters to their UNC path names

Signed-off-by: Robert Minsk <[email protected]>
Signed-off-by: Robert Minsk <[email protected]>
Signed-off-by: Robert Minsk <[email protected]>
@herronelou
Copy link
Contributor

Nice, I found the same issue and was going to patch on my side

@herronelou
Copy link
Contributor

herronelou commented Aug 4, 2025

@JeanChristopheMorinPerso Can either this or #1543 be reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Environment resolution uses UNC paths with Python 3.10, 3.7 was using mounted network drives.

2 participants