-
Notifications
You must be signed in to change notification settings - Fork 347
Package repository case insensitive error handling #2 #1974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Package repository case insensitive error handling #2 #1974
Conversation
Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
==========================================
+ Coverage 60.02% 60.06% +0.04%
==========================================
Files 163 163
Lines 20118 20120 +2
Branches 3506 3507 +1
==========================================
+ Hits 12075 12086 +11
+ Misses 7223 7220 -3
+ Partials 820 814 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: BryceGattis <[email protected]>
case_mismatch_package = create_package("MyTestPackage", data={}) | ||
case_mismatch_variant = next(case_mismatch_package.iter_variants()) | ||
|
||
pkg_repository._create_variant(variant, overrides={}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this leave files behind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe so. I will confirm. The TempdirMixin should handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the folder is cleaned up. There are some other unit tests that are not properly cleaning up their temp folders though. I will push an update to this PR.
Co-authored-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Bryce Gattis <[email protected]>
Co-authored-by: Jean-Christophe Morin <[email protected]> Signed-off-by: Bryce Gattis <[email protected]>
@JeanChristopheMorinPerso One thing that I could use some help on, from poking around, I expected that adding this new test file would allow me to do
Looking at selftest, it should be autogenerated as a new flag. Do you have any idea why it's not working? |
…olders Signed-off-by: BryceGattis <[email protected]>
…//github.com/BryceGattis/rez into hotfix/create_variant_case_mismatch_handling
@BryceGattis They should appear in |
It was due to a typo in the filename 🤦 |
Signed-off-by: BryceGattis <[email protected]>
Remake of the original PR #1951 on my personal GitHub.
Closes #1931.
This adds a new unit test for the fix as well.