Improvement move pkg cache fs calls to repo plugin #1993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to decouple the package cache operation to the repository plugins
First commit moves only the copytree function call to the base repo class
While the second commit moves other fs calls like os.path.isdir and os.stat to the variant resource class
This can allow users to customize how the package cache touches the filesystem on a per repository bases either via the cache_variant() call, or on the variant resource
Does this help with the artifact repo direction, could some remote repos use the current cache system via moving these functions to the repository plugin?
I personally would like a way to customize pkg cache operation via a custom filesystem plugin to optimize cache speeds