Skip to content

Conversation

@vanridal
Copy link
Contributor

@vanridal vanridal commented Jul 7, 2025

This PR is an attempt to decouple the package cache operation to the repository plugins
First commit moves only the copytree function call to the base repo class
While the second commit moves other fs calls like os.path.isdir and os.stat to the variant resource class

This can allow users to customize how the package cache touches the filesystem on a per repository bases either via the cache_variant() call, or on the variant resource

Does this help with the artifact repo direction, could some remote repos use the current cache system via moving these functions to the repository plugin?

I personally would like a way to customize pkg cache operation via a custom filesystem plugin to optimize cache speeds

@vanridal vanridal requested a review from a team as a code owner July 7, 2025 23:27
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.12%. Comparing base (dac6bcb) to head (a8ff4bc).

Files with missing lines Patch % Lines
src/rez/package_cache.py 66.66% 1 Missing ⚠️
src/rez/package_resources.py 80.00% 1 Missing ⚠️
src/rez/packages.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1993      +/-   ##
==========================================
+ Coverage   60.11%   60.12%   +0.01%     
==========================================
  Files         163      163              
  Lines       20098    20109      +11     
  Branches     3494     3494              
==========================================
+ Hits        12082    12091       +9     
- Misses       7205     7207       +2     
  Partials      811      811              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant