Skip to content

Conversation

@Ni-g-3l
Copy link
Contributor

@Ni-g-3l Ni-g-3l commented Oct 20, 2025

Hey !

I found that on pre_test_command, "base" and "root" bindings were missing.

They are still available with "{this.base}" or "{this.root}", however I think it's important to keep consistency between available callback inside package.py

Feel free to comment or ask me question :)

@Ni-g-3l Ni-g-3l requested a review from a team as a code owner October 20, 2025 16:06
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.97%. Comparing base (dac6bcb) to head (57030ac).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/rez/package_test.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
- Coverage   60.11%   59.97%   -0.15%     
==========================================
  Files         163      163              
  Lines       20098    20120      +22     
  Branches     3494     3519      +25     
==========================================
- Hits        12082    12067      -15     
- Misses       7205     7232      +27     
- Partials      811      821      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ni-g-3l Ni-g-3l force-pushed the feat-add-missing-base-root-pre-test-cmd branch from ddd2a1a to 57030ac Compare October 21, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant