OCIO view hotkeys, working_space, and file-path remapping #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedwaine
force-pushed
the
develop
branch
3 times, most recently
from
4b886d5 to
8cde0df
Compare
…data value through xstudio's file-path remapping mechanism. Likewise, all the search paths within the config are also passed through file path remapping. Note that any path set via the OCIO environment variable is left as-is. Signed-off-by: Ken McGaugh <[email protected]>
…ur management metadata. We use this to set the working_space to "raw" for media we want to remain unmanaged but still allow for the global view to be set without causing error messages. Signed-off-by: Ken McGaugh <[email protected]>
… Ctrl+1 through Ctrl+9 (linux) and each select the the corresponding view for the current display. Under MacOS these are Cmd+1 through Cmd+9. Signed-off-by: Ken McGaugh <[email protected]>
Signed-off-by: Ken McGaugh <[email protected]>
kenmcgaugh
force-pushed
the
ocio_additions
branch
from
fd62d31 to
58d0915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several additions to OCIO colour management.
The first is the addition of Meta+1 through Meta+9 hotkeys for changing the current OCIO view. (Ctrl+1 through Ctrl+9 under MacOS). Note that the commit message mistakenly stated the wrong modifier key. If this conflicts with other's hotkeys I can take it out of this PR or put it behind a preference.
Next, this adds support for utilising xSTUDIO's file-path remapping mechanism to remap OCIO config files specified via metadata and also any search paths within the config.
Finally, this allows the setting of the working_space via the colour management metadata. We find this useful for viewing both colour managed and unmanaged clips together while also using a global OCIO view. By setting the working_space to "raw" on the unmanaged clips, the OCIO view will be disregarded without complaint.