Fix python event routing sender mismatch for playhead events#270
Open
richardssam wants to merge 1 commit into
Open
Fix python event routing sender mismatch for playhead events#270richardssam wants to merge 1 commit into
richardssam wants to merge 1 commit into
Conversation
- Resolve issue where playhead events (position_atom, etc.) were silently dropped in the Python API. When C++ event groups broadcast messages, the sender is set to the owner actor (e.g. Playhead) rather than the event group address. - Add support for mapping callback IDs to an optional owner actor address in EventToPythonThreadLockerActor. - Update subscribe_to_playhead_events in plugin_base.py and subscribe_to_event_group in module.py to pass the owner actor as the third argument to add_message_callback. Signed-off-by: Sam.Richards@taurich.org <Sam.Richards@taurich.org> (cherry picked from commit 30c92c49afc21d4b3ff4ddf6c69f751db646fca4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have to be honest, this is code from gemini, I was trying to use the event system as much as I could, so tried using the playhead, but ran into problems getting the information from it, so if there is a better way to get playhead events to python let me know.