Skip to content

Conversation

@zjb0807
Copy link
Member

@zjb0807 zjb0807 commented Nov 10, 2025

No description provided.

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.86%. Comparing base (bb8e6c4) to head (7b676f1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2941   +/-   ##
=======================================
  Coverage   47.86%   47.86%           
=======================================
  Files          83       83           
  Lines        9566     9566           
=======================================
  Hits         4579     4579           
  Misses       4987     4987           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zjb0807 zjb0807 requested a review from Copilot December 10, 2025 02:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the RemoveXTokensMigrationStatus migration from both the Acala and Karura runtimes, indicating that the migration has been completed and is no longer needed. The migration was responsible for cleaning up the XTokens::MigrationStatus storage key.

  • Removed the RemoveXTokensMigrationStatus struct and its OnRuntimeUpgrade implementation
  • Changed the Migrations type from containing the migration to an empty tuple ()

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
runtime/karura/src/lib.rs Removed migration code and set Migrations to empty tuple
runtime/acala/src/lib.rs Removed migration code and set Migrations to empty tuple

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zjb0807 zjb0807 marked this pull request as ready for review December 10, 2025 03:07
@zjb0807 zjb0807 requested a review from xlc December 10, 2025 03:07
@xlc xlc merged commit eb004a3 into master Dec 10, 2025
10 of 11 checks passed
@xlc xlc deleted the clean-migrations branch December 10, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants