ci: add release workflow and versioned docker builds#5
Open
ChristophBe wants to merge 1 commit intomainfrom
Open
ci: add release workflow and versioned docker builds#5ChristophBe wants to merge 1 commit intomainfrom
ChristophBe wants to merge 1 commit intomainfrom
Conversation
ChristophBe
force-pushed
the
ci/add-semantic-versioning
branch
2 times, most recently
from
d2877aa to
66c5fbe
Compare
chore: run build on all tags
ChristophBe
force-pushed
the
ci/add-semantic-versioning
branch
from
66c5fbe to
a754af9
Compare
jxhnx
reviewed
Oct 21, 2024
| - name: Determine Image Tag | ||
| if: ${{ github.ref_type == 'branch' }} | ||
| run: | | ||
| echo \"IMAGE_TAG=${{env.NEXT_RELEASE_VERSION}}-pre-release-$(git rev-parse --short ${{ github.sha }})\" >> $GITHUB_ENV |
Member
There was a problem hiding this comment.
Will NEXT_RELEASE_VERSION be available? Since semantic release runs in a different job.
Comment on lines
+11
to
+13
| push: | ||
| tags: | ||
| - '**' |
Member
There was a problem hiding this comment.
I'm not sure if this will ever trigger when we use another workflow to tag a commit. Last time I looked workflows could not trigger other workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.