-
Notifications
You must be signed in to change notification settings - Fork 38
Feature/984: bulk update notification email addresses #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
phjulia
wants to merge
71
commits into
develop
Choose a base branch
from
feature/984-feature-bulk-update-notification-email-addresses
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
b09acd1
#984: setNotifEmailAddr command added
phjulia 000778e
#984: added a function to update notifications for Automations
phjulia 76dda3e
#984: move updateNotifications under runMethod
phjulia 49440b9
#984: enable updating notes or email addresses, additional checks, mo…
phjulia 10a3fe3
#984: added 2 test cases for updateNotifications
phjulia 19f1318
#984: updated function name
phjulia 24543f0
#984: updateNotifications improvements
phjulia 581a3a1
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
phjulia 0f1c3fe
#984: fixed tests, adjusted logic to set some notifications, check if…
phjulia 48e37e1
#984: fixed tests - +2 api requests because there is a new test autom…
phjulia e7c93c2
#984: moved repetitive code into #getEncodedAutomationIDs()
phjulia 92dfd6e
#984: added interactive questions, no email validation at this point
phjulia 9934cbd
#984: corrected test
phjulia 83f679d
#984: remove notifications option
phjulia ae4cc5d
#984: added email validator
phjulia 309de98
#984: added a test for importFile
phjulia 94d8c11
#984: added a test for --clear option
phjulia 18cd195
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
phjulia ceefc04
#984: +1 test automations, the rest of the tests were adapted
phjulia 127e1e4
#984: --clear option for importFile
phjulia d87161a
#984: exit updateNotifications for importFile if user provided option…
phjulia 00704bf
#984: note was not set if email address was not provided
phjulia 3910110
#984: retrive for clearNotifications is already covered
phjulia e8f7744
#984: some improvements and more tests
phjulia 556d256
#984: ternary -> if
phjulia 1d30d9e
#984: removed error variable
phjulia 051b215
Update test/type.importFile.test.js
phjulia 9f822f6
Update test/type.automation.test.js
phjulia 720231c
#984: test update completion email address and error email address
phjulia 739eaf8
#984: +9 positive test cases
phjulia 10bf762
Merge branch 'feature/984-feature-bulk-update-notification-email-addr…
phjulia a38f02b
#984: +1 negative test case
phjulia 6d87df6
#984: group:
phjulia eff4b1a
#984: moved properties out of static variables
phjulia 55a3389
#984: removed static variables
phjulia d07cf91
Update lib/cli.js
phjulia 47c847d
#984: made getKeysToSetNotifications in MetadataType abstract, moved …
phjulia e07fba6
Merge branch 'feature/984-feature-bulk-update-notification-email-addr…
phjulia 5bdfa31
#984: clearNotifications was removed from MetadataType and index
phjulia 4cc50b3
#984: info to verbose
phjulia 592d3fb
#984: renamed negative test cases
phjulia 989fed4
#984: renamed negative test cases
phjulia 695afb0
#984: renamed test cases
phjulia fc03b1d
#984: split a test case into 2
phjulia 729eb96
#984: split a test case into 3
phjulia f691e6c
#984: +3 tests for clearNotifications (+3 cached automations, +6 API …
phjulia 3023492
#984: improved regex email validation
phjulia 9abe1e5
#984: moved type specific stuff into child class
phjulia 1609171
#984: removed options from updateNotifications command
phjulia 9bb5be7
#984: added a test for updating a note only
phjulia 0dc51ae
#984: +1 automation
phjulia 23d0cea
#984: added a function to retrieve and deploy that is used for fixKey…
phjulia 12f7b3d
#984: regex for email validation replaced
phjulia fe22dca
#984: add questions to an array
phjulia 0b43078
#984: validate added
phjulia 6c09a25
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
phjulia 9ddbefe
#984: test cases
phjulia f1ff0de
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
phjulia c18e6ef
#984: +15 automations/+15 API calls
phjulia 7b0de99
#984: fixed issue with email validation
phjulia 1101102
#984: merge develop into branch
phjulia 7fb1fb4
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
JoernBerkefeld af22fb9
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
JoernBerkefeld bd755f4
#0: auto-formatting
JoernBerkefeld 258c067
#984: improve log message for updateNotification
JoernBerkefeld 63f9784
#984: move updateNotification logic from custom createOrUpdate into p…
JoernBerkefeld 8e2670a
#984: rename importFile test for updateNotification
JoernBerkefeld 9981086
#984: refactoring
JoernBerkefeld 801317d
Merge branch 'develop' into feature/984-feature-bulk-update-notificat…
JoernBerkefeld f1df201
#0: pre-commit hook logs
JoernBerkefeld 6626df6
#984: fix tests for importFile & query
JoernBerkefeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
#npm run docs | ||
#git update-index --add docs/dist/documentation.md | ||
echo "[PRE-COMMIT] Re-creating documentation..." | ||
npm run docs | ||
git update-index --add docs/dist/documentation.md | ||
|
||
echo "[PRE-COMMIT] Running lint-staged..." | ||
npx --no lint-staged |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.