Test - uncommitted changes by make all should fail CI#1
Closed
Acepresso wants to merge 2 commits into
Closed
Conversation
Currently, `make test` is used to detect uncommitted file changes, but it missed some targets that modify files (e.g. "make docs"). Update the workflow to also run `make all`, to ensure that all relevant file-generating targets are executed before checking for uncommitted changes. Refs: https://issues.redhat.com/browse/EC-1262
This is a test to validate a new CI test, that checks if there are no uncommitted files generated by `make all`, should fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to validate enterprise-contract#525.
Running make all from this PR should generate uncommitted files. This is intentional, to see if the new CI test will catch that and fail.
DO NOT MERGE!