Refactor notebook glob expansion to use filesystem-driven matching#21
Open
Refactor notebook glob expansion to use filesystem-driven matching#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
classpath/modulepathrelative patterns resolve consistently and expand to concrete file paths before launch.PathMatcherrather than manual regex parsing and ad-hoc prefix handling for more robust glob support.Description
Pathand checking filesystem existence inNotebookUtils.expandGlobPathsso existing paths are preserved and non-existing entries are considered for expansion.expandGlobEntry(String pattern, Path entryPath)which locates the nearest existing ancestor viafindExistingRootand usesFileSystems.getDefault().getPathMatcher("glob:" + pattern)to match candidates under that root.NotebookConfigsto callNotebookUtils.expandGlobPathswhen buildingclassPathandmodulePathso configuration entries are expanded consistently.Testing
NotebookUtilsTest.testExpandGlobPathsto exercise filesystem glob expansion andNotebookConfigsTest.testGlobExpansionForNotebookPathsto validate integration with configuration initialization.Codex Task