Skip to content

✨ Feat: Parse 400 errors body to access message #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Feat: Parse 400 errors body to access message #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions wake/development/json_rpc/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import json
from urllib.request import Request, urlopen
from urllib.request import Request, urlopen, HTTPError

from wake.utils import get_package_version

Expand Down Expand Up @@ -30,5 +30,10 @@ def send_recv(self, data: str):
},
)

with urlopen(req, timeout=self._timeout) as response:
return json.loads(response.read().decode("utf-8"))
try:
with urlopen(req, timeout=self._timeout) as response:
return json.loads(response.read().decode("utf-8"))
except HTTPError as e:
if e.code >= 400 and e.code < 500:
return json.loads(e.file.read().decode("utf-8"))
raise e
Loading