fix(SVGDepictor): escape string injected in svg#144
Merged
thsa merged 1 commit intoActelion:masterfrom Sep 1, 2025
Merged
Conversation
I discover it was not escaped, so we could write xml tag into custom atom labels. I did not succeed to run js from custom label but I'm pretty sure it's possible. This is a security fix to avoid remote code execution (XSS in browser or directly in OS with svg preview in desktop file explorer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discover it was not escaped, so we could write xml tag into custom atom labels.
I did not succeed to run js from custom label but I'm pretty sure it's possible.
This is a security fix to avoid remote code execution (XSS in browser or directly in OS with svg preview in desktop file explorer).