-
Notifications
You must be signed in to change notification settings - Fork 8
Sync production v15.3.1 + Sharrow #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bhargavasana It would be great if someone at SANDAG could review this PR, including (especially) running some performance test on the "large" data on SANDAG servers, to confirm not only that it runs but also that turning on sharrow makes it run significantly faster, on the platform that matters. I've tested locally and this code works for me (with ~50% time savings over the legacy code) but no one really cares if it works on a macOS laptop, the real proof is when it works on a large Windows server. Thanks! |
Sure, I will get this tested on a SANDAG server this week. |
|
Alexander Berryhill-Williams [email protected] via email ...
|
This pull request builds on #37, adding compatibility with sharrow.
Several scripts are included to run various legacy and sharrow tests: https://github.com/driftlesslabs/sandag-abm3-example/tree/sync_production_v15.3.1/scripts