Skip to content

fix(ci): sign macOS artifacts only on release tags #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimeToBuildBob wants to merge 1 commit into
base: master
Choose a base branch
from
+26 −4
Open

fix(ci): sign macOS artifacts only on release tags #1348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,18 @@ jobs:
- name: Package dmg
if: runner.os == 'macOS'
run: |
if [ -n "$APPLE_EMAIL" ]; then
SIGN_MACOS=false
if [[ "${GITHUB_REF:-}" == refs/tags/v* ]]; then
SIGN_MACOS=true
fi

if [ "$SIGN_MACOS" = true ]; then
for var in APPLE_EMAIL APPLE_PASSWORD APPLE_TEAMID CERTIFICATE_MACOS_P12_BASE64 CERTIFICATE_MACOS_P12_PASSWORD; do
if [ -z "${!var:-}" ]; then
echo "ERROR: $var is required to sign macOS release artifacts" >&2
exit 1
fi
done
./scripts/ci/import-macos-p12.sh
APPLE_PERSONALID=$(security find-identity -v -p codesigning "${KEY_CHAIN:-build.keychain-db}" | sed -n 's/.*"\(.*\)"/\1/p' | head -1)
if [ -z "$APPLE_PERSONALID" ]; then
Expand All @@ -381,7 +392,7 @@ jobs:
source venv/bin/activate
make dist/ActivityWatch.dmg

if [ -n "$APPLE_EMAIL" ]; then
if [ "$SIGN_MACOS" = true ]; then
codesign --force --verbose --timestamp -s "${APPLE_PERSONALID}" dist/ActivityWatch.dmg

brew install akeru-inc/tap/xcnotary
Expand Down Expand Up @@ -592,7 +603,18 @@ jobs:
- name: Package dmg
if: runner.os == 'macOS'
run: |
if [ -n "$APPLE_EMAIL" ]; then
SIGN_MACOS=false
if [[ "${GITHUB_REF:-}" == refs/tags/v* ]]; then
SIGN_MACOS=true
fi

if [ "$SIGN_MACOS" = true ]; then
for var in APPLE_EMAIL APPLE_PASSWORD APPLE_TEAMID CERTIFICATE_MACOS_P12_BASE64 CERTIFICATE_MACOS_P12_PASSWORD; do
if [ -z "${!var:-}" ]; then
echo "ERROR: $var is required to sign macOS release artifacts" >&2
exit 1
fi
done
./scripts/ci/import-macos-p12.sh
APPLE_PERSONALID=$(security find-identity -v -p codesigning "${KEY_CHAIN:-build.keychain-db}" | sed -n 's/.*"\(.*\)"/\1/p' | head -1)
if [ -z "$APPLE_PERSONALID" ]; then
Expand All @@ -605,7 +627,7 @@ jobs:
source venv/bin/activate
make dist/ActivityWatch.dmg

if [ -n "$APPLE_EMAIL" ]; then
if [ "$SIGN_MACOS" = true ]; then
codesign --force --verbose --timestamp -s "${APPLE_PERSONALID}" dist/ActivityWatch.dmg

brew install akeru-inc/tap/xcnotary
Expand Down
Loading