Add Top Stopwatch Events view

[wojnilowicz]

In order for the stopwatch events to appear, one has to enable "Force devmode" in the settings and have some stopwatch events.

The stopwatch events are merged with window events. If they overlap, then the stopwatch events have precedence, so that no more than 24 h of all events are logged per day.

---

Important

Adds a new view for top stopwatch events, integrating it into the visualization framework and ensuring proper data handling and querying.

• Behavior:
  • Adds top_stopwatches view in SelectableVisualization.vue to display top stopwatch events.
  • Stopwatch events are merged with window events using union_no_overlap in canonicalEvents() in queries.ts.
• Data Handling:
  • Adds top_stopwatches to stopwatch state in activity.ts.
  • Implements query_stopwatch_completed() in activity.ts to update stopwatch data.
• Queries:
  • Modifies fullDesktopQuery() in queries.ts to include stopwatch events processing.
  • Ensures stopwatch events are sorted and limited by duration in fullDesktopQuery().
• Misc:
  • Adds top_stopwatches to visualization types and checks for availability in SelectableVisualization.vue.

^{This description was created by for 324e30b. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 324e30b in 2 minutes and 6 seconds

More details

• Looked at 124 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 14 drafted comments based on config settings.

1. src/components/SelectableVisualization.vue:88

• Draft comment:
  Ensure that 'with_limit' prop is defined in the aw-summary component or passed correctly.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the author to ensure that a property is defined or passed correctly. This is a general request for confirmation and does not provide a specific suggestion or point out a specific issue. It violates the rule against asking the author to ensure something is done without being specific.

2. src/components/SelectableVisualization.vue:250

• Draft comment:
  Confirm that activityStore.stopwatch.available accurately reflects the stopwatch data availability.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the PR author to confirm the accuracy of a specific variable's reflection of data availability. This falls under asking the author to confirm their intention or to double-check things, which is against the rules.

3. src/queries.ts:148

• Draft comment:
  Verify that union_no_overlap(stopwatch_events, events) correctly prioritizes stopwatch events as intended.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the PR author to verify the behavior of a function, which is against the rules. It doesn't provide a specific suggestion or point out a clear issue with the code.

4. src/queries.ts:359

• Draft comment:
  Double-check that sorting and limiting of stopwatch_events aligns with other groups and default_limit.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  This comment is asking the PR author to double-check the sorting and limiting of stopwatch_events. It doesn't provide a specific suggestion or point out a clear issue, which violates the rule against asking the author to double-check things.

5. src/stores/activity.ts:734

• Draft comment:
  Ensure that query_stopwatch_completed is called appropriately when include_stopwatch is true.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the author to ensure that a function is called appropriately based on a condition. This is similar to asking the author to double-check their work, which violates the rules. The comment does not provide a specific suggestion or point out a specific issue.

6. src/stores/activity.ts:117

• Draft comment:
  Review the new 'top_stopwatches' state property initialization. It should be an empty array.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

7. src/components/SelectableVisualization.vue:88

• Draft comment:
  New top_stopwatches view added using aw-summary. Verify that using e.data.label for both name and color is correct and that the shorthand 'with_limit' is handled as intended.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 40% <= threshold 50%
  The comment is asking the PR author to verify the correctness of using e.data.label for both name and color, and to ensure that the shorthand with_limit is handled as intended. This violates the rule against asking the author to confirm their intention or ensure behavior is intended. However, it does point out specific areas of potential concern, which could be useful for the author to consider. The comment could be rephrased to suggest a review of these areas without directly asking for verification.

8. src/components/SelectableVisualization.vue:157

• Draft comment:
  Added 'top_stopwatches' to the allowed types and computed visualizations mapping. Ensure that the availability flag (using activityStore.stopwatch.available) correctly reflects when stopwatch data is present.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 20% <= threshold 50%
  The comment is asking to ensure that the availability flag correctly reflects the presence of stopwatch data. This is similar to asking the author to double-check or verify something, which is against the rules. The comment does not provide a specific code suggestion or ask for a specific test to be written.

9. src/queries.ts:145

• Draft comment:
  Replaced period_union with union_no_overlap for merging stopwatch events, giving stopwatch events precedence. Confirm that the union_no_overlap function correctly handles overlapping intervals.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

10. src/queries.ts:360

• Draft comment:
  Stopwatch events are merged by keys ('label'), sorted, and limited. Verify that using 'label' as the grouping key is the intended behavior for aggregating top stopwatch events.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the PR author to verify if using 'label' as the grouping key is the intended behavior. This falls under asking the author to confirm their intention, which is against the rules. The comment does not provide a specific suggestion or point out a clear issue.

11. src/stores/activity.ts:734

• Draft comment:
  New query_stopwatch_completed method updates stopwatch.top_stopwatches with returned data. Confirm that this method is properly triggered when include_stopwatch is true.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the author to confirm that a method is properly triggered under a certain condition. This falls under the rule of not asking the author to confirm their intention or ensure behavior is intended. Therefore, this comment should be removed.

12. src/stores/activity.ts:381

• Draft comment:
  In query_desktop_full, the conditional call to query_stopwatch_completed based on include_stopwatch is added. Ensure this condition and the corresponding bucket check (this.buckets.stopwatch.length) meet the intended behavior.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the author to ensure that a condition and a corresponding check meet the intended behavior. This falls under asking the author to confirm their intention, which is against the rules. The comment does not provide a specific suggestion or point out a clear issue, making it not useful according to the guidelines.

13. src/queries.ts:103

• Draft comment:
  Typo in the comment at line 103: "Puts it's results..." should be "Puts its results...".
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

14. src/queries.ts:105

• Draft comment:
  Typo in the comment on line 105: "unecessary" should be "unnecessary".
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_g5Qw0BaCZ8QeUqIn

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[codecov]

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.70%. Comparing base (b1959cf) to head (fa72857).

Files with missing lines	Patch %	Lines
src/stores/activity.ts	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
- Coverage   26.76%   26.70%   -0.07%     
==========================================
  Files          28       28              
  Lines        1655     1659       +4     
  Branches      280      281       +1     
==========================================
  Hits          443      443              
- Misses       1186     1190       +4     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ErikBjare]

If they overlap, then the stopwatch events have precedence, so that no more than 24 h of all events are logged per day.

This (emph) might be surprising to some. Can this at least be documented in the code somewhere? Didn't realize when I reviewed it.

[ErikBjare]

Very nice! Happy to see someone finally fixed this obvious oversight.

[wojnilowicz]

If they overlap, then the stopwatch events have precedence, so that no more than 24 h of all events are logged per day.

This (emph) might be surprising to some. Can this at least be documented in the code somewhere? Didn't realize when I reviewed it.

Maybe at

aw-webui/src/views/activity/Activity.vue

Line 68 in 9842d3e

| #[b Note:] WIP, breaks aw-server-rust badly. Only shown in devmode.

by changing from
#[b Note:] WIP, breaks aw-server-rust badly. Only shown in devmode.
to
#[b Note:] WIP. Stopwatch events shadow other events, when overlapping with them. Only shown in devmode.

[wojnilowicz]

@ErikBjare I already added the note. Could you merge now?