-
-
Notifications
You must be signed in to change notification settings - Fork 130
style: fix Raw JSON visibility in dark mode #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: fix Raw JSON visibility in dark mode #736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 1541e26 in 22 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. static/dark.css:11
- Draft comment:
Good fix: including pre and code ensures that Raw JSON in dark mode gets a light text color. Verify this doesn't unintentionally override other code styling if needed. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_GOz09JqP2csx2k5B
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Greptile SummaryThis PR fixes a dark mode visibility issue where Raw JSON output displayed in The change is minimal, surgical, and follows the existing pattern in Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Browser
participant App.vue
participant Theme Settings
participant dark.css
participant SelectableEventView
User->>Theme Settings: Enable dark mode
Theme Settings->>Browser: Create link element
Browser->>dark.css: Load /dark.css
dark.css->>Browser: Apply dark theme styles
Note over dark.css: Sets pre, code { color: #e9ebf0 !important }
User->>SelectableEventView: Select "Raw JSON" view
SelectableEventView->>Browser: Render <pre> with events data
Browser->>Browser: Apply color from dark.css rule
Browser->>User: Display light text on dark background
|
Greptile found no issues!From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
|
Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 26.30% 26.30%
=======================================
Files 29 29
Lines 1684 1684
Branches 288 301 +13
=======================================
Hits 443 443
Misses 1219 1219
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Fixed an issue where the "Raw JSON" query output was effectively invisible in Dark Mode because it lacked specific styling and inherited a dark text color from the base theme.
Changes
static/dark.cssto explicitly setpreandcodetags to a light color (#e9ebf0) in the dark theme.Verification
npm run serve) connected to a testing server (aw-server --testing).Important
Fixes dark mode visibility issue for 'Raw JSON' by setting light text color for
preandcodeinstatic/dark.css.static/dark.cssto setpreandcodetags to color#e9ebf0for better visibility in dark mode.npm run serveand confirmed readability of Raw JSON output.This description was created by
for 1541e26. You can customize this summary. It will automatically update as commits are pushed.