Skip to content

Ports -- Kate #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
goblineer wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ports -- Kate #39

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63ff482
Brought up to passing tests.
goblineer Feb 28, 2019
1328bae
Update for completion
goblineer Feb 28, 2019
5a8733a
Trying to fix merge
goblineer Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions lib/array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
# Determines if the two input arrays have the same count of elements
# and the same integer values in the same exact order
def array_equals(array1, array2)
raise NotImplementedError
end
i = 0
if (array1 == nil) && (array2 == nil)
Copy link
Copy Markdown

@ace-n ace-n Apr 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: these if statements are a bit redundant - how about combining some of them, e.g:

if (array1 == nil && array2 == nil) {
  return true;
} elsif (array1 == nil || array2 == nil) {
  return false;
}
...

return true
elsif (array1 == nil) && (array2 != nil)
return false
elsif (array1 != nil) && (array2 == nil)
return false
elsif array1.length != array2.length
return false
else
Copy link
Copy Markdown

@ace-n ace-n Apr 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit: the else is redundant here. You can move this inner block out of it. 🙂

array1.length.times do
if array1[i] != array2[i]
return false
else
i += 1
end
end
end
return true
end