Open
Conversation
CheezItMan
reviewed
May 12, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
You have a good idea here, but a few bugs in your binary search. Take a look at my inline comments and let me know if you have questions.
| return true | ||
| elsif array[mid] < value_to_find | ||
| i = mid + 1 | ||
| j = array.length - 1 |
There was a problem hiding this comment.
You are ending up reseting the top value of your search criteria here! This line shouldn't be here!
| end | ||
| return intersection | ||
| else | ||
| array = array2.sort |
There was a problem hiding this comment.
In this else you're not setting i to zero.
| mid = array.length / 2 | ||
| i = 0 | ||
| j = array.length - 1 | ||
| while i < j |
There was a problem hiding this comment.
Is this really what you want for the while loop here? What if the array is 1 element in size?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.