Conversation
aribray
left a comment
aribray
left a comment
There was a problem hiding this comment.
You should make sure all of these tests are passing
|
Is it possible to have acronyms with special characters? Maybe the tests should account for those. |
| end | ||
|
|
||
| def test_lowercase_words | ||
| skip |
There was a problem hiding this comment.
Don't forget to remove skip to make sure the tests are passing.
KateAnnNichols
left a comment
KateAnnNichols
left a comment
There was a problem hiding this comment.
Can you explain what the regex is targeting? Thanks!
| # Common test data version: 1.7.0 cacf1f1 | ||
| class AcronymTest < Minitest::Test | ||
| def test_basic | ||
| # skip |
There was a problem hiding this comment.
You can remove this commented out code.
JansenMartin
left a comment
JansenMartin
left a comment
There was a problem hiding this comment.
It seems like we're skipping most of these tests. Was that intentional?
| def test_consecutive_delimiters | ||
| skip | ||
| assert_equal "SIMUFTA", Acronym.abbreviate('Something - I made up from thin air') | ||
| end |
There was a problem hiding this comment.
What do we want to happen if the value is nil?
| @@ -0,0 +1,5 @@ | |||
| module Acronym | |||
| def self.abbreviate(value) | |||
| value.scan(/\b\w/).map(&:upcase).join | |||
There was a problem hiding this comment.
Can we use a descriptive variable and an explicit return here?
goblineer
left a comment
goblineer
left a comment
There was a problem hiding this comment.
One of my instructors told me that submitting code with skipped tests would get me in big trouble. I won’t tell him if you don’t. 🤐
7 participants
No description provided.