Skip to content

Sockets - Tatiana #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tatsqui wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Sockets - Tatiana #33

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c57dec
first way to solve this algorithm
tatsqui Mar 29, 2019
7731927
"tests pass"
tatsqui Mar 29, 2019
0827c2f
added space complexity
tatsqui Apr 8, 2019
1238ed2
added clearer variable name
tatsqui Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions lib/factorial.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
# Computes factorial of the input number and returns it
# Time complexity: ?
# Space complexity: ?
# Time complexity: On!
# Space complexity: Constant
Copy link
Copy Markdown

@jadevance jadevance Apr 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to explain your reasoning behind time and space complexity.

def factorial(number)
raise NotImplementedError
end
raise ArgumentError, "Bad Value" if number == nil
Copy link
Copy Markdown

@jadevance jadevance Apr 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to also cover bad string integer input, consider:
raise ArgumentError, "Bad Value" if number.is_a?(Integer) == false || number == nil


return 1 if number == 0 || number == 1

minus_one = number - 1
until minus_one == 0
number *= minus_one
minus_one -= 1
end
return number
Copy link
Copy Markdown

@jadevance jadevance Apr 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this method! 🦄 👍

end