Skip to content

Sockets - Shubha #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shubha-rajan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sockets - Shubha #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a6fdfa
initial commit. all tests pass, works for nominal cases
shubha-rajan Apr 14, 2019
621b980
added answers to time/space complexity questions
shubha-rajan Apr 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lib/factorial.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
# Computes factorial of the input number and returns it
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(n) because number of iterations is dependent on the size of the input number
# Space complexity: O(1) because only one int value (factorial) is ever stored
def factorial(number)
raise NotImplementedError
if number
factorial = 1
while number > 0
factorial *= number
number -= 1
end
return factorial
else
raise ArgumentError, "Input must be an integer"
Copy link
Copy Markdown

@jadevance jadevance Apr 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend having error handling at the top rather than the bottom so you break early. Something such as:

if !number 
  raise
else 
  do factorial
end

Otherwise good job on this assignment!

end
end