Skip to content

Ports - Shamira #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MiraMarshall wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ports - Shamira #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/factorial.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
# Computes factorial of the input number and returns it
# Time complexity: ?
# Space complexity: ?
# Time complexity: ? O(n) - linear with n being the number input.
# Space complexity: ? O(n) with n being the number input for the factorial.
Copy link
Copy Markdown

@CheezItMan CheezItMan May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are not using an array or anything, the space complexity is O(1). If n gets bigger the amount of memory used doesn't increase.

def factorial(number)
raise NotImplementedError
if number == nil || number < 0
raise ArgumentError, "Need positive integer"
end
factorial = 1
while number >= 1
factorial *= number
number = number - 1
end
return factorial
end