Open
Conversation
|
Nice work! |
CheezItMan
reviewed
May 12, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice recursive solution. See my notes on the space and time complexities. You could get to O(1) space complexity with a loop instead of recursion. Any ideas?
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) with n being the input. | ||
| # Space complexity: O(1)- constant because it take the same amount of space regardless of the input. |
There was a problem hiding this comment.
Space complexity is actually dependent on the number of recursive calls. Each time you make a call to fibonacci it has to save the previous call in the stack.
|
|
||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) with n being the input. |
There was a problem hiding this comment.
Actually your solution is O(2^n) in time complexity. We'll talk about this in the recursion lesson.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.