Open
Conversation
CheezItMan
reviewed
Sep 18, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Really nice, I like how you thought to break down the Sudoku problem into smaller methods. You got all the problems here. Nice work!
|
|
||
| # Checks whether there is any | ||
| # duplicate in current column or not. | ||
| def in_column?(table) |
There was a problem hiding this comment.
These in_row and in_column methods don't look very dry here.
| end | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Minor thing: I suggest a return true here.
|
|
||
| # Checks whether there is any duplicate | ||
| # in current 3×3 box or not. | ||
| def in_box?(table) |
There was a problem hiding this comment.
This is a really slick method! Nice
| # in the case of a tie it will select the first occurring element. | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def top_k_frequent_elements(list, k) |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # in the case of a tie it will select the first occurring element. | ||
| # Time Complexity: O(n) |
There was a problem hiding this comment.
Looking at your later loop, I would say this is O(k * n)
| # Each subarray will have strings which are anagrams of each other | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) |
There was a problem hiding this comment.
Assuming the words are small, this is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hash Table Practice
Congratulations! You're submitting your assignment!
Comprehension Questions