Open
Conversation
CheezItMan
reviewed
Oct 18, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Hey Kate, thanks for the PR.
Most of the methods you have work great. If you find time to finish the rest ping me and I'll take a look at them. Please review my comments and let me know if you have questions or if I'm not making sense. One thing I'd like is to see you indicate the time & space complexity of each method.
| @@ -21,39 +21,85 @@ def initialize | |||
| # Time Complexity: | |||
| # Space Complexity | |||
| def add_first(value) | |||
| # returns true if found, false otherwise | ||
| # Time Complexity: | ||
| # Space Complexity | ||
| def search(value) |
| # returns the data value and not the node | ||
| # Time Complexity: | ||
| # Space Complexity | ||
| def find_max |
| # returns the data value and not the node | ||
| # Time Complexity: | ||
| # Space Complexity | ||
| def find_min |
| current = @head | ||
|
|
||
| while current | ||
| i++ |
There was a problem hiding this comment.
++ doesn't really work as an operator in Ruby. It treats this as i plus some positive number.
Suggested change
| i++ | |
| i += 1 |
| # method to delete the first node found with specified value | ||
| # Time Complexity: | ||
| # Space Complexity | ||
| def delete(value) |
| @@ -120,7 +184,8 @@ def has_cycle | |||
| # Time Complexity: | |||
| # Space Complexity | |||
| def get_first | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.