Open
Conversation
CheezItMan
reviewed
May 12, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
This definitely works and has good space & time complexities. You do end up having to make multiple passes through the matrix, once to change 1s to xs and another to change Xs to 0s. You might think about how you could use the 1st row and column to keep track of the values to zero out.
Overall well done.
|
|
||
| def convert_one_to_x_where_zero_is_found(matrix) | ||
| i = 0 | ||
| while matrix[i] != nil |
There was a problem hiding this comment.
Maybe a while i < matrix.length is more appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.