Skip to content

Ports - Kim#15

Open
Kimberly-Fasbender wants to merge 1 commit intoAda-C11:masterfrom
Kimberly-Fasbender:master
Open

Ports - Kim#15
Kimberly-Fasbender wants to merge 1 commit intoAda-C11:masterfrom
Kimberly-Fasbender:master

Conversation

@Kimberly-Fasbender
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass + analysis LGTM. Nice work! 😄

Edit: I reckon the time complexity on this is better than O(n^3). Any idea why? (Hint: is the zero-setting code within the second block of loops executing for every value in the matrix?)


rows.times do |row|
cols.times do |col|
matrix[row][col] = "x" if matrix[row][col] == 0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of temporary state tracking here! 👍

(This technique becomes super-relevant when you start working with things like graphs and trees.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants