Conversation
ace-n
left a comment
ace-n
left a comment
There was a problem hiding this comment.
Tests pass and code style looks good! Nice work! 👍
The time complexity analysis looks right - any ideas on how we can improve the space one?
| # If any number is found to be 0, the method updates all the numbers in the | ||
| # corresponding row as well as the corresponding column to be 0. | ||
| # Time complexity: O(n*m), where n and m are nums of rows and columns | ||
| # Space complexity: O(n + m), where n and m are nums of rows and columns |
There was a problem hiding this comment.
Space complexity looks better than n + m to me. 🙂
Any ideas on what it might be?
There was a problem hiding this comment.
Oh, good question! So ... since this method doesn't create any extra structures to hold data, is it just constant? This was my first try at a matrix and I think I forgot that all it is is a single particularly organized array. O(n)?
There was a problem hiding this comment.
I'd agree with the former - if you wanted to be super-technically correct, you could say "constant additional space". (Excluding the size of your input and output variable(s) is a matter of convention).
| columns.times do |column| | ||
| next unless matrix[row][column] == "ZERO" | ||
|
|
||
| columns.times { |i| matrix[row][i] = 0 unless matrix[row][i] == "ZERO" } |
There was a problem hiding this comment.
Personal preference nit: some programmers (e.g. many Java people) might find this a bit too concise, and will prefer something more explicit.
Rubyists, unlike Java people, sometimes embrace this conciseness even if it makes code take slightly more time to understand - as it results in less code needing to be understood. 🙂
(Of course - like all personal preferences, this one's totally up to you.)
There was a problem hiding this comment.
Thank you! It's really helpful to hear about style preferences. When I work on this sort of thing in a vacuum, I can get totally drawn into the temptation to make it beauuuuuutifully elegant and forget about clarity/other people 😮 🙂
There was a problem hiding this comment.
Yep - and style preferences depend heavily on the existing codebase. Many codebases/companies will have style guides, but inevitably your first few PRs at a new company (or even a new codebase within the same company! - e.g. iOS vs. Android) will be spent learning (and internalizing) that codebases' specific guidelines/patterns.
2 participants
No description provided.