Ports - Laneia && Mina by laneia · Pull Request #10 · Ada-C11/ride-share-rails

laneia · 2019-04-19T22:58:20Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Trip belongs to Passenger and Driver and both Passenger and Driver have many trips. This is because passengers and drivers will utilize the rideshare service potentially many times, but each trip should be its own unique instance with only one passenger and driver.
Describe the role of model validations in your application	Our validations are ensuring that users enter required fields before saving or editing information. It's very helpful as some methods rely on that information, so this can keep them from failing.
How did your team break up the work to be done?	We divided up work fairly and evenly based on project requirements and individual interests. Passengers and drivers work were similar so we split those duties up, came together on trips, and split styling/HTML and testing.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized functionality but as far as I know we did not set any features aside. We included styling for additional readability.
What was one thing that your team collectively gained more clarity on after completing this assignment?	The use of let in testing and how it can lead to unexpected test failures.
What is your Trello board URL?	https://trello.com/b/Cb5koffQ/rideshare
What is the Heroku URL of your deployed application?	https://raise-the-roof.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We both felt like we balanced each other's strengths and weaknesses well and we also felt like we worked very well together overall.

CheezItMan · 2019-04-26T20:23:50Z

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing
Answered comprehension questions	Check, let can cause unexpected failures if you use the let variable after the controller action.
Uses named routes (like `_path`)	Check
RESTful routes utilized	Check, good work taking out unneeded routes.
Project Requirements
Table relationships	Check
Business logic is in the models	Check
Controller tests	Mostly missing
Database is seeded from the CSV files	Check
Trello board is created and utilized in project management	Check
Heroku instance is online	Check
The app is styled to create an attractive user interface	Decent styling
Overall	You have most of the requirements, except testing. You also don't prevent a passenger from requesting a trip, if they already have an unrated trip. You also have no way to take drivers online and offline. However, except for testing, those are minor. Let me know any questions you have about my comments.

CheezItMan · 2019-04-26T20:00:31Z

+
+  resources :drivers
+
+  resources :trips, except: [:index, :create]


CheezItMan · 2019-04-26T20:02:08Z

-    # Your tests go here
-  end
-end
+# require "test_helper"


Hmmm... so no tests here

CheezItMan · 2019-04-26T20:02:20Z

@@ -1,31 +1,149 @@
-require "test_helper"
+# require "test_helper"


No tests here as well

CheezItMan · 2019-04-26T20:02:59Z

+        cost: 1000,
+      },
+    }
+    it "can update an existing trip" do


What about updating a trip with invalid arguments?

CheezItMan · 2019-04-26T20:03:25Z


-  describe "destroy" do
-    # Your tests go here
+    it "will respond with not found if invalid id" do


What about destroying a valid trip?

CheezItMan · 2019-04-26T20:18:42Z

+    total_money = 0
+
+    if (trips.length > 0)
+      trips.each do |trip|


You could use .sum

CheezItMan · 2019-04-26T20:19:17Z

+      return 0.0
+    end
+
+    trips.each do |trip|


You could use .where to get trips with a rating and .sum.

CheezItMan · 2019-04-26T20:19:26Z

+class Trip < ApplicationRecord
+  belongs_to :driver
+  belongs_to :passenger
+  validates :date, :cost, presence: true


CheezItMan · 2019-04-26T20:19:38Z

@@ -0,0 +1,12 @@
+class Passenger < ApplicationRecord
+  has_many :trips, dependent: :destroy


Good use of dependent: destroy

CheezItMan · 2019-04-26T20:19:54Z

+class Passenger < ApplicationRecord
+  has_many :trips, dependent: :destroy
+  validates :name, :phone_num, presence: true
+


I suggest making a model method for a passenger to request a trip.

minams and others added 30 commits April 15, 2019 14:46

setup new rails project

4a39dee

added database and migrated

47417ea

added relationships in ruby files

8774bc1

hey look a commit on my new branch

485560e

added index to homepages

81f5319

Merge branch 'master' of https://github.com/minams/ride-share-rails

d1ba546

changes to homepages

14445dd

added driver index by name method

480a852

added Driver#show method

897de0b

added driver edit method, edited show method

937987a

added driver update method

18de3b6

added driver new method

46d8166

added driver create method

5096a53

renamed driver_params to driver_info

783e61e

added private driver_info method

322420a

added driver destroy method

ed582c4

added routes and methods for passenger

b20fa7a

added driver validation

92831ab

added skeleton for money_earned and average_rating driver methods

56fbfd6

added items to html files

8d66153

added money_earned method for driver

4c54840

added driver average_rating method

b1754da

added validates_associated :trips to driver.rb

301f773

added validation to trip.rb

8766102

Remove spurious model tests

466f5c6

added index test for drivers controller

858e956

added first test

f03edb4

removed model tests

efdf64a

added more tests for driver controller

9b25312

Merge branch 'master' of https://github.com/minams/ride-share-rails

dc02f42

laneia and others added 28 commits April 19, 2019 03:59

fixing merge conflicts

fadcedf

passenger show conflict fixed

2980068

added colon after driver names

b634fd3

fixed driver money earned math

e4cb287

finished *fingers crossed* styling

250bc99

changed add driver redirect to new driver show page

77828ce

added trips route

243ad97

added availability status to driver

afee839

fixed add trip and edit trip

8723911

add precompiled assets for heroku

d1fc3a8

fixing typos

53fef3a

changed heroku related settings

99ce1dd

completed passenger tests

141e874

Merge branch 'master' of https://github.com/minams/ride-share-rails

1ee7130

fixing more typos

5084991

Merge branch 'master' of https://github.com/minams/ride-share-rails

c65a4b7

drivers tests passing

156e171

changed background img hosting

ebeb478

Merge branch 'master' of https://github.com/minams/ride-share-rails

219872d

fixed more more typos

da95d84

Merge branch 'master' of https://github.com/minams/ride-share-rails

4c3a9a3

rehosting img

b3b1806

rehost img

f45a0ee

re re re re hosting an img

f5f8fdc

maybe the last image rehosting?

51ef3fe

added some trip controller tests

af5eb39

Merge branch 'master' of https://github.com/minams/ride-share-rails

c89e9d9

passing trip tests

61b09a2

CheezItMan reviewed Apr 26, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ports - Laneia && Mina#10

Ports - Laneia && Mina#10
laneia wants to merge 107 commits intoAda-C11:masterfrom
minams:master

laneia commented Apr 19, 2019

Uh oh!

CheezItMan commented Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

CheezItMan Apr 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		resources :drivers

		resources :trips, except: [:index, :create]

		@@ -1,31 +1,149 @@
		require "test_helper"
		# require "test_helper"

		@@ -0,0 +1,12 @@
		class Passenger < ApplicationRecord
		has_many :trips, dependent: :destroy

Conversation

laneia commented Apr 19, 2019

Rideshare-Rails

Comprehension Questions

Uh oh!

CheezItMan commented Apr 26, 2019

Rideshare Rails

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants