Sockets - Pauline and Riyo by RPerry · Pull Request #14 · Ada-C11/ride-share-rails

RPerry · 2019-04-19T23:42:50Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Trips belong to passenger and driver, drivers have many trips, passengers have many trips.
Describe the role of model validations in your application	It allows us to require certain parameters for an instance to be created. Combined with strong params, this gives our app a measure of security.
How did your team break up the work to be done?	Pulled tickets from our trello board and coordinated over slack.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	Prioritized getting the database correctly set up and made sure to fulfill the user stories before starting on design. Due to this, we had to set aside many of our design goals because of time constraints.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Nested routes
What is your Trello board URL?	https://trello.com/b/lBhnjLjK/rideshare-rails
What is the Heroku URL of your deployed application?	https://priyo-rideshare.herokuapp.com/passengers
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We discussed that establishing our preferred methods of communication, directness about what the other would like us to do and what is expected of us. We thought the project went well in terms of what was accomplished

…or handling

…nger column from respective show

… can rate their previous trip regardless of whether there are available drivers

kaidamasaki · 2019-04-30T19:44:39Z

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and all team members contributing	👍🏽
Answered comprehension questions	👍🏽
Uses named routes (like `_path`)	👍🏽
RESTful routes utilized	Mostly. See inline comments.
Project Requirements
Table relationships	👍🏽
Business logic is in the models	👍🏽
Controller tests	👍🏽
Database is seeded from the CSV files	👍🏽
Trello board is created and utilized in project management	👍🏽
Heroku instance is online	👍🏽
The app is styled to create an attractive user interface	👍🏽
Overall	While your app overall was very strong it looks like you were unable to resist the siren call of the last minute code change. Remember, when you make a change always run your tests and fix failures, even if you are in a hurry. The instinct to clean up your code was good, but you do need to be extra careful when you're approaching a deadline. It also looked like you had some trouble with nested routes. Generally when you have a one-to-many relationship it's worth at least considering whether or not you should nest routes there. You were really close here, it's just something to pay a little extra attention to in the future. Aside from the issues above everything looked great though, good job!

kaidamasaki · 2019-04-26T22:35:09Z

+// <h1>Welcome to the Trip List</h1>
+
+// <ul>
+//   <% @trips.each do |driver| %>


I'm not sure what happened here. It looks like maybe this file was supposed to be commented out or just not checked in at all.

This seems like it was definitely supposed to look like this though:

Suggested change

// <% @trips.each do |driver| %>

// <% @trips.each do |trip| %>

Also the fact that trip doesn't exist causes errors with the rest of the view.

kaidamasaki · 2019-04-26T22:39:48Z

+
+  post '/drivers/:id/available', to: 'drivers#available', as: "driver_availability"
+  # post '/drivers/:id/destroy', to: 'drivers#destroy', as: "destroy_driver"
+  # post '/passengers/:id/destroy', to: 'passengers#destroy', as: "destroy_passenger"


It looks like these were removed at the last minute but were still referenced by tests.

kaidamasaki · 2019-04-26T22:46:04Z

+  Total Fare Paid: $<%= @passenger.total_fare %>
+</p>
+
+<% if @passenger.trips.last.rating == nil %>


This causes a test (works for a passenger that exists) to fail. (You will get an undefined method `rating' for nil:NilClass when there are no trips for the passenger.)

It also causes the same error when trying to show a newly created Passenger.

You need to make sure that @passenger.trips.last isn't nil before calling rating:

Suggested change

<% if @passenger.trips.last.rating == nil %>

<% if @passenger.trips.last && @passenger.trips.last.rating == nil %>

kaidamasaki · 2019-04-30T18:23:10Z

+          return
+        end
+
+        if driver.available == true


Tip: you can leave off the == true here in Ruby it's implied.

kaidamasaki · 2019-04-30T18:26:10Z

+
+        if driver.available == true
+            driver.available = !driver.available
+        elsif driver.available == false || driver.available == nil


Tip: since false and nil are the only "falsey" objects in Ruby this could simply be:

Suggested change

elsif driver.available == false || driver.available == nil

elsif !driver.available

kaidamasaki · 2019-04-30T18:56:54Z

+
+        trip.destroy
+
+        redirect_to trips_path


This should redirect to the appropriate Passenger or Driver. See notes on routes.rb.

kaidamasaki · 2019-04-30T19:05:46Z

@@ -0,0 +1,26 @@
+<h1>Welcome to the Driver List</h1>
+
+<ul>


Tip: a <table> can make displaying this sort of information easier.

kaidamasaki · 2019-04-30T19:13:19Z

@@ -0,0 +1,5 @@
+class AddDriverIdColumnToTrips < ActiveRecord::Migration[5.2]
+  def change
+    add_reference :trips, :driver, foreign_key: true


Tip: you are allowed to run multiple commands in a single change method.

kaidamasaki · 2019-04-30T19:16:56Z

+  root 'homepages#index'
+
+  resources :drivers
+  resources :trips


Trips should have been nested under :drivers as well.

kaidamasaki · 2019-04-30T19:18:23Z

+  resources :trips
+
+  resources :passengers do
+    resources :trips, only: [:index, :new, :create]


trips#new shouldn't live here since the passenger isn't treated specially when you make a new trip.

paulentine and others added 30 commits April 15, 2019 15:31

Generate new Rails app

6ef64a4

added driver model

af297c3

Add Trip & Passenger models

858bab1

Add Passenger & Trip models

273dd6a

added trip_id reference to driver and passenger

2fdcbf1

Modify models to contain relationship reference

ec855e5

changed phone number column name

53fdbb5

Add driver_id & passenger_id references to trips

e4559a7

Remove spurious model tests

a911757

Create Passenger Model, Controller, Views

15209e4

added drivers and trips controller and tests

32dbfec

added drivers and trip controllers and tests

53c82a9

added view for driver

811b3ca

fixed some tests

b397e78

fixing trips tests

aad5d48

Tests all Passenger class actions

bf24543

Merge branch 'master' of https://github.com/RPerry/ride-share-rails

ce0c617

fixed the create test for trips

bd8aa28

all tests pass

65d4cc9

fixed driver tests

91c269c

finished driver details page with table

4c61d44

Add drop down nav bar

efb138c

Merge branch 'master' of https://github.com/RPerry/ride-share-rails

c849a37

finished trip details page with ability to rate trip

57e094a

Generate Homepages controller, setup root index.html.erb

b658bde

Merge branch 'master' of https://github.com/RPerry/ride-share-rails

0676e23

Add nested routes for Passengers' Trips (index, new, create)

45d421d

Fixed typo

2cab56f

Update trips controller to handle nested routes for new & index + err…

a05fad2

…or handling

Migrated Drivers to add column available

da164c1

RPerry and others added 28 commits April 18, 2019 18:21

test still broken

54d9207

Merge branch 'master' of https://github.com/RPerry/ride-share-rails

6f49bec

test still broken

104398b

new trip button in passenger show when rated and available drivers

f9ee60d

Add Google fonts

00ab50a

Merge branch 'master' of https://github.com/RPerry/ride-share-rails

7b46624

trips controller tests are fixed and pass

52ea36e

Merge branch 'master' of https://github.com/RPerry/ride-share-rails

439ce2b

created online/offline button for drivers

cac4bb4

Stylize online & offline buttons, nav bar

f55c487

Style retired

472bcab

car make in new driver form to drop down and deleted driver and passe…

622dc9c

…nger column from respective show

Make button links white

8992947

Add favicon

30d4a57

car model

c2ee488

Merge branch 'master' of https://github.com/RPerry/ride-share-rails

59c7ff4

DRY up driver's views

be18102

Refactor, DRY up code

98de9cf

fixed same driver issue

9c00f31

DRY up routes

3a25812

Better delete messages

c89b4d4

Merge branch 'master' of https://github.com/RPerry/ride-share-rails

a0d6d42

Minor style changes

de58c8c

Remove text decoration from nav bar links

b87a88b

changed the order of the loop in passenger show so that the passenger…

227b54d

… can rate their previous trip regardless of whether there are available drivers

Add helper method to show cost in dollars

bda4fa2

Merge branch 'master' of https://github.com/RPerry/ride-share-rails

570d0e2

Use to_dollars helper method

f765218

kaidamasaki reviewed Apr 30, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sockets - Pauline and Riyo#14

Sockets - Pauline and Riyo#14
RPerry wants to merge 73 commits intoAda-C11:masterfrom
RPerry:master

RPerry commented Apr 19, 2019

Uh oh!

kaidamasaki commented Apr 30, 2019

Uh oh!

kaidamasaki Apr 26, 2019

Uh oh!

kaidamasaki Apr 26, 2019

Uh oh!

kaidamasaki Apr 26, 2019

Uh oh!

kaidamasaki Apr 30, 2019

Uh oh!

kaidamasaki Apr 30, 2019

Uh oh!

kaidamasaki Apr 30, 2019

Uh oh!

kaidamasaki Apr 30, 2019

Uh oh!

kaidamasaki Apr 30, 2019

Uh oh!

kaidamasaki Apr 30, 2019

Uh oh!

kaidamasaki Apr 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// <% @trips.each do \|driver\| %>
	// <% @trips.each do \|trip\| %>

	<% if @passenger.trips.last.rating == nil %>
	<% if @passenger.trips.last && @passenger.trips.last.rating == nil %>

	elsif driver.available == false \|\| driver.available == nil
	elsif !driver.available

Conversation

RPerry commented Apr 19, 2019

Rideshare-Rails

Comprehension Questions

Uh oh!

kaidamasaki commented Apr 30, 2019

Rideshare Rails

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants